[CDAP-21079] Implement cdap-messaging-spi extension for spanner - Part 1 #15750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masoud-io
reviewed
Dec 3, 2024
cdap-tms/src/main/java/io/cdap/cdap/messaging/client/DelegatingMessagingService.java
Outdated
Show resolved
Hide resolved
cdap-tms/src/main/java/io/cdap/cdap/messaging/service/CoreMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
masoud-io
reviewed
Dec 8, 2024
cdap-messaging-spi/src/main/java/io/cdap/cdap/messaging/spi/MessagingService.java
Outdated
Show resolved
Hide resolved
masoud-io
reviewed
Dec 10, 2024
masoud-io
reviewed
Dec 10, 2024
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
masoud-io
reviewed
Dec 10, 2024
cdap-tms/src/main/java/io/cdap/cdap/messaging/client/DefaultMessagingServiceContext.java
Outdated
Show resolved
Hide resolved
sidhdirenge
changed the title
masoud-io
reviewed
Dec 12, 2024
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
masoud-io
approved these changes
Dec 13, 2024
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
...saging-ext-spanner/src/main/java/io/cdap/cdap/messaging/spanner/SpannerMessagingService.java
Outdated
Show resolved
Hide resolved
sidhdirenge
force-pushed
the
spanner-messaging-1
branch
from
c521b75 to
e73ad93
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement methods like createTopic(), publish() etc.
Follow up PR to include changes for fetch().
The code is tested in autopush project.
Junits are tested by setting the system properties, as done in SpannerStructuredAdminTest.
